Skip to content

fix(test): Add cypress exception#2290

Merged
enjeck merged 5 commits intomainfrom
fix-cypress
Feb 4, 2026
Merged

fix(test): Add cypress exception#2290
enjeck merged 5 commits intomainfrom
fix-cypress

Conversation

@enjeck
Copy link
Contributor

@enjeck enjeck commented Jan 30, 2026 •
edited
Loading

Current tests are failing due to the exception Cannot read properties of undefined (reading 'from')

@enjeck enjeck self-assigned this Jan 30, 2026
@enjeck enjeck requested a review from blizzz as a code owner January 30, 2026 04:56
@enjeck enjeck added the 3. to review Waiting for reviews label Jan 30, 2026
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Office team Jan 30, 2026
@juliusknorr
Copy link
Member

juliusknorr commented Jan 30, 2026

It would be good to add some context where that is originating from and ideally report with the corresponding repository (as I assume it is something from server)

@enjeck
Copy link
Contributor Author

enjeck commented Jan 30, 2026

It would be good to add some context where that is originating from and ideally report with the corresponding repository (as I assume it is something from server)

I believe it's from:
https://github.com/nextcloud/server/blob/master/core/src/utils/RedirectUnsupportedBrowsers.js#L36

@enjeck
Copy link
Contributor Author

enjeck commented Jan 30, 2026

Created bug report at nextcloud/server#57920

@blizzz
Copy link
Member

blizzz commented Jan 30, 2026

Are they, or do they fail only in #2286? Could it be related to changes in cypress-custom.yml then?

@enjeck
Copy link
Contributor Author

enjeck commented Feb 2, 2026

Are they, or do they fail only in #2286? Could it be related to changes in cypress-custom.yml then?

Nope, they do not only fail there.

@enjeck enjeck mentioned this pull request Feb 2, 2026
Merged
enjeck added 2 commits February 3, 2026 03:32
@enjeck
fix(test): Add cypress exception
2abf3f0 
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
@enjeck
fix: Cast share id to string, fix test
f41a959 
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
@enjeck
Copy link
Contributor Author

enjeck commented Feb 3, 2026

on stable branches, we hit an unsupported browser screen, so all tests fail:

Test column date and time -- Insert and test rows - default now (failed)

@enjeck
fix(test): Handle unsupported browser screen
5451aef 
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
@enjeck
Copy link
Contributor Author

enjeck commented Feb 3, 2026

In fix(test): Handle unsupported browser screen, made it so that we just click the continue button to proceed

enjeck added 2 commits February 3, 2026 07:49
@enjeck
fix: Handle different submission types for older NC
646c81b 
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
@enjeck
fix(test): target first submit item
06d422a 
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
@enjeck enjeck merged commit d486ac2 into main Feb 4, 2026
58 of 65 checks passed
@enjeck enjeck deleted the fix-cypress branch February 4, 2026 05:34
@github-project-automation github-project-automation bot moved this from 🧭 Planning evaluation (don't pick) to ☑️ Done in 📝 Office team Feb 4, 2026
@enjeck
Copy link
Contributor Author

enjeck commented Feb 4, 2026

/backport to stable1.0

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Feb 4, 2026
@backportbot backportbot bot mentioned this pull request Feb 4, 2026
Merged
2 tasks
@backportbot backportbot bot removed the backport-request Pending backport by the backport-bot label Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blizzz blizzz Awaiting requested review from blizzz blizzz is a code owner

Assignees

@enjeck enjeck

Labels

3. to review Waiting for reviews

Projects

📝 Office team
Status: ☑️ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@enjeck @juliusknorr @blizzz